[Seoya0512] WEEK1 solutions #2000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaeKwangho
reviewed
Nov 13, 2025
Contributor
BaeKwangho
left a comment
BaeKwangho
left a comment
There was a problem hiding this comment.
정성스러운 주석 덕분에 리뷰가 재밌었습니다. 남은 시간도 화이팅 하세요
top-k-frequent-elements/Seoya0512.py
Outdated
| - 버킷을 뒤에서부터 순회하며 상위 k개 숫자 채우기: O(n) | ||
|
|
||
| Space Complexity: O(n) | ||
| - freq 딕셔너리와 bucket 리스트로 인해 O(n) 발생 |
Contributor
There was a problem hiding this comment.
freq 딕셔너리가 없어서 살짝 헷갈렸어요. hash_map 을 말씀하시는게 맞을까요?
top-k-frequent-elements/Seoya0512.py
Outdated
| for num in nums: | ||
| hash_map[num] = hash_map.get(num, 0) + 1 | ||
|
|
||
| # 인덱스 = 등장 횟수, 값 = 그 횟수만큼 등장한 숫자 리스트 |
Contributor
There was a problem hiding this comment.
최대한 작성해두신 구현방식을 이해해보려고 했는데, 어려웠던 것 같아요!
예시 포맷을 작성해 두는 것도 좋은 방법일 것 같습니다. 저도 그래야겠어요 ㅎㅎ...
Suggested change
| # 인덱스 = 등장 횟수, 값 = 그 횟수만큼 등장한 숫자 리스트 | |
| # e.g) let nums = [1,6,6,3,2,6,8], bucket = [[1,3,2,8],[],[6]] |
Contributor
Author
There was a problem hiding this comment.
오오 좋은 주석 방식 공유해주셔서 감사합니다
| return [] | ||
|
|
||
| ''' | ||
| (개선) |
Contributor
|
코드 리뷰 주신 내용을 보고 참고하고자 확인해봤는데 너무 잘 작성되어 있어서 한 수 배우고 갑니다. ㅎㅎ |
TonyKim9401
approved these changes
Nov 16, 2025
Contributor
TonyKim9401
left a comment
TonyKim9401
left a comment
There was a problem hiding this comment.
1주차 문제 풀이 고생하셨습니다!
온보딩 및 스터디 적응 하시는데 앞으로 조금 더 힘내주시고 앞으로의 15주간 여정 응원합니다.
2주차 문제 풀이도 파이팅입니다!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!